search

scmbreeze / scm_breeze

Adds numbered shortcuts to the output git status, and much more
https://madebynathan.com/2011/10/19/git-shortcuts-like-youve-never-seen-before/
MIT License
2.82k stars 192 forks source link

Refactor of git status #262

Closed ghthor closed 5 years ago

ghthor commented 5 years ago

Long time coming. Let's dogfood this for a bit, but I think it'll work well. I left the legacy version in the source code for now so it's a little bit easier to hack it back in if this break anything for anyone.

HaleTom commented 5 years ago

I suggest you parse git status -z --porcelain=v2

ghthor commented 5 years ago

I agree with this. The main blocker I have here is that my ruby knowledge is pretty newbie and the syntax/concepts were tripping me up a lot just getting this into merge. I did revert this with #269 with the TODO being, learn enough ruby to parse git status -z --porcelain=v2. ETA, unknown, maybe I should fill out an Issue with my plan so anyone can signal that they're working on it, if I don't get to it quickly enough.

jeffbyrnes commented 5 years ago

I may be able to help with that; my Ruby chops are decent. I’ll try to find some time this week to check it out.

ghthor commented 5 years ago

That'd be awesome!_! You need any guidance at all about what we think needs to get done to fit this sonny in, don't hesitate!

On Mon, Sep 10, 2018 at 6:45 PM Jeff Byrnes notifications@github.com wrote:

I may be able to help with that; my Ruby chops are decent. I’ll try to find some time this week to check it out.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/scmbreeze/scm_breeze/pull/262#issuecomment-420063324, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJyKnDgWB_fZHg0V18po_7QnhEKiUBwks5uZtYkgaJpZM4WVyjR .

HaleTom commented 5 years ago

@jeffbyrnes Thanks for the offer! I'd be willing to review your code.

jeffbyrnes commented 5 years ago

Haven‘t yet had any bandwidth to tackle this, sorry! One day soon, I hope.