Closed HaleTom closed 5 years ago
Oops, I just read that it's a bad idea to git push
with -f
to a PR branch.
I did it at 2018-09-02 05:30 UTC if it helps to de-fuxor things at your end.
Awaiting "Upgrade Travis CI environment to newer versions of bash and zsh #264" to proceed.
@HaleTom Thanks for the include, but I think you might be referring to @ndbroadbent instead.
This PR is shaping up really nicely! I need to fix that Travis_CI build #264
This is finally green with Travis.
Can I please get a LGTM or two?
@HaleTom @jeffbyrnes Any more reservations? Can I get a LGTM for my conflict resolution in a8cf407?
@ghthor and @nathanb could I have your feedback on this PR? Also, please tag anyone else you believe should review this PR.
Fixes
ll dir1 dir2
"What's in the can:
scmb_expand_args()
viadeclare -p
. This array can then be reconstituted in the caller byeval "args=$(scmb_expand_args "$@")"
._safe_eval()
: quote$@
elements beforeeval
to prevent, eg,eval "echo" "foo;date"
from runningdate
. With_safe_eval
, the output will befoo;date
._token_quote
test helper which prints the shell-escaped version of each of its arguments.$IFS
: use locally scoped$IFS
variables.$@
with"$@"
to prevent splitting of array elements by $IFS${array[@]}
with "${array[@]}"readlink -f
in a way which can succeedstrip_colors()
to pass tests$LS_COLOURS
as set by https://github.com/trapd00r/LS_COLORSassert(Not)?Includes
: call_includes
with an arraytest_helper.sh
: Don't clobber global name/email configshell_shortcuts_test.sh
: correct quotingscmb_expand_args()
: return an array to fix quoting issues_print_path
: remove unnecessary pipelinetest_ls_with_file_shortcuts()
: clean up temp files after usels_with_file_shortcuts()
: print error to STDERRrun_tests.sh
to be executed from anywherels
invocations inls_with_file_shortcuts
git_show_affected_files:
make$f
localMay fix #183: "Breaks cd when using other languages" (awaiting reproduction instructions)
May contain traces of peanuts. Reviews gratefully received.