scmbreeze / scm_breeze

Adds numbered shortcuts to the output git status, and much more
https://madebynathan.com/2011/10/19/git-shortcuts-like-youve-never-seen-before/
MIT License
2.82k stars 192 forks source link

Git status shortcuts broken edge case: moved file #267

Open LeZuse opened 5 years ago

LeZuse commented 5 years ago

To reproduce simply move a checked in file from a previous commit and stage it. Git detects a moved file:

$ git status
# On branch: master  |  [*] => $e
#
➤ Changes to be committed
#
#        renamed: [1] "app.js -> app2.js"

$e1 now contains invalid filename:

$ echo $e1
/Users/zuse/Projects/pb-frontend/apps/main/"app.js -> app2.js"
$ git --version
git version 2.10.2
$ cd ~/.scm_breeze/
$ git show --oneline
8a326c2 Merge pull request #262 from ghthor/refactor_of_git_status
ghthor commented 5 years ago

I fixing this by reverting for now. We need better test coverage to handle a major change like the refactorization that was merged in #262