Declare scmb_wrapped_shell_commands as array

scmbreeze / scm_breeze

Adds numbered shortcuts to the output git status, and much more

MIT License

2.82k stars 192 forks source link

Closed Stephen2 closed 4 months ago

Stephen2 commented 2 years ago

Closes #315 Closes #297 Closes #284

Stephen2 commented 2 years ago

I don't have knowledge of how to test this thoroughly.

But it works in bash and it fixes zsh for wrapping the commands

Thought I'd throw it up for review in case there's nothing else to it

wrightak commented 1 year ago

I've made these changes locally. Would be great to merge for the sake of new users.

jeffbyrnes commented 4 months ago

Seems like this was superseded by #331, and can simply be closed & deleted now?

Stephen2 commented 4 months ago

Excellent! Thanks @jeffbyrnes for the notification, and @ghthor for the other fix :)

ghthor commented 4 months ago

331 I think actually doesn't work and I refocused on getting some CI set back up to make sure the tests are working.

This PR might actually be the correct way to do it. I'm actively working on this

Stephen2 commented 4 months ago

NP! I'll not delete the branch, in case you wanna reopen or anything, all yours