scmbreeze / scm_breeze

Adds numbered shortcuts to the output git status, and much more
https://madebynathan.com/2011/10/19/git-shortcuts-like-youve-never-seen-before/
MIT License
2.82k stars 192 forks source link

Fixed completions for 'gl' and 'gla' aliases #319

Closed telzhov closed 4 months ago

telzhov commented 1 year ago

Closes #320

ghthor commented 1 year ago

This changes the argument definition from a single string into an array of strings? That seems fine to me.

telzhov commented 1 year ago

Right, because __git_alias function defined above in that file expects the argument list split into array:

__git_alias () {
    ...
    if [ $# -gt 2 ]; then
      shift 3 2>/dev/null
      cmd_args=("$@")
    fi
telzhov commented 11 months ago

Hi, I see that this PR hasn't been accepted so far. You don't find these changes really useful, don't you?.. Thanks!

jeffbyrnes commented 4 months ago

Would sure be nice to have this merge in!

ghthor commented 4 months ago

Hi, I see that this PR hasn't been accepted so far. You don't find these changes really useful, don't you?.. Thanks!

No, I've just been lazy

telzhov commented 3 months ago

Hi, I see that this PR hasn't been accepted so far. You don't find these changes really useful, don't you?.. Thanks!

No, I've just been lazy

Thanks a lot!