Fixes #100 Pass in user defined options to CM constructor in componentDidMount

scniro / react-codemirror2

Codemirror integrated components for React

MIT License

1.66k stars 193 forks source link

Fixes #100 Pass in user defined options to CM constructor in componentDidMount #113

Closed twheys closed 4 years ago

twheys commented 6 years ago

Added second argument to CodeMirror constructor in componentDidMount with the options prop.

coveralls commented 6 years ago

Coverage decreased (-1.5%) to 81.864% when pulling 970ab279c8c4563f654e5df9648cd68c244181df on twheys:master into 3d29515e00e20c70691645db45937bc40c209a12 on scniro:master.

Nishchit14 commented 5 years ago

This is the perfect solution but incomplete PR :(

scniro commented 4 years ago

@twheys @Nishchit14 I am a lot shorter on time these days as when I started this project. Codemirror & React APIs are moving to quickly for me to keep atop of for the day-to-day. I am looking for a co-maintainer of this project. Please contact me directly if you are interested. Thank you for understanding.

elsigh commented 4 years ago

@scniro I'm willing to help this PR and help collaborate on this project if you're up for having another maintainer.

elsigh commented 4 years ago

@Nishchit14 is this incomplete just for missing a test?

elsigh commented 4 years ago

@twheys - any interest in getting this landed? I think adding a test and ensuring that the code doesn't re-apply options after setting them in the constructor seems good too? If you're busy I can take this one over.

elsigh commented 4 years ago

closing in favor of https://github.com/scniro/react-codemirror2/pull/188