Updated peer dependency for React 17

scniro / react-codemirror2

Codemirror integrated components for React

MIT License

1.65k stars 192 forks source link

Updated peer dependency for React 17 #224

Closed ihollander closed 2 years ago

ihollander commented 3 years ago

Fixes #223

coveralls commented 3 years ago

Coverage remained the same at 79.868% when pulling 64597ae3267aebdff6af867d5105e44f739e09f2 on ihollander:master into 3d490109229e8592772db922e9028c9a1dee3336 on scniro:master.

Sceurpien commented 3 years ago

Seems ok :D

TAO44123 commented 3 years ago

Fixes #223

I try to change the package.json file like you, but no use for me...

bn185069 commented 3 years ago

Is anyone able to merge this? This PR has been open since Nov 17 2020

skystebnicki commented 3 years ago

Yes please, we are also depending on this merge.

bn185069 commented 3 years ago

Hey @mattjared or anyone else available, if it's not too much trouble can you merge this PR for us?

sachinraja commented 3 years ago

If anyone still wants this, just install from @ihollander's fork: npm install https://github.com/ihollander/react-codemirror2. It's clear this package isn't getting updated anyway. This also fixes #228

RomanHotsiy commented 3 years ago

Hey @scniro, could you merge this, please? This is a 2 lines PR.

abdulrahman-khankan commented 3 years ago

@fongandrew @mattjared @drewswaycool could you please merge this PR if you still have write access? Thank you 🙌

drewswaycool commented 3 years ago

@fongandrew @mattjared @drewswaycool could you please merge this PR if you still have write access? Thank you 🙌

I don't, sorry 🤷‍♂️.

LeifAndersen commented 3 years ago

If anyone cares, I got tired waiting and pushed a version of react-codemirror2 with this patch to npm:

npm install @leifandersen/react-codemirror2