search

scniro / react-codemirror2

Codemirror integrated components for React
MIT License
1.65k stars 192 forks source link

Updating React Version in package.json #273

Open Bhavesh588 opened 2 years ago

Bhavesh588 commented 2 years ago

The npm show error of React version should be less then 16.x so I updated to current new version 17.0.2

fongandrew commented 2 months ago

Sorry for the delay in responding to this. If you're still interested in bumping the version, give it a go but check in the updated package-lock.json file as well.

Bhavesh588 commented 2 months ago

So do you want me to update the package-lock.json file? and then make the pull request?

fongandrew commented 2 months ago

Yes, whenever bumping package.json, you should also update package-lock.json if there's checked in. You can bump React to the latest v18 if you want too.

fongandrew commented 2 months ago

Oh wait -- actually, you might have to hold on that. This package uses Enzyme for testing and there's no official Enzyme adapter for React beyond v16. We'd need to migate the tests away from Enzyme to something else for this to work unfortunately.