scniro / react-codemirror2

Codemirror integrated components for React
MIT License
1.65k stars 192 forks source link

Codemirror support for react v18? #293

Open MielkeDaniel opened 1 year ago

MielkeDaniel commented 1 year ago

Has someone discovered a way to run codemirror in react v18? I rather do not want to downgrade my react version again...

kaushikc44 commented 1 year ago

Even I am facing some issues.

curiosity110 commented 1 year ago

Did you guys found a way?

MielkeDaniel commented 1 year ago

Naaah not explicitly. If you want to use Codemirror via React you can not use this library. You´ll have to integrate the "normal" codemirror yourself. I´m using the newest version (Codemirror 6) right now. You can watch some tutorials and read the docs. It´s kinda tricky to get into but all makes sense in the end.

https://codemirror.net/

Good luck

kaushikc44 commented 1 year ago

Yes , I found a way , https://uiwjs.github.io/react-codemirror/ I used this, and it worked for me , you can check here www.codevim.tech

curiosity110 commented 1 year ago

Thanks for your reply I am gonna try with this one https://uiwjs.github.io/react-codemirror/

if doens't work i am gonna build my own Thanks so much!

MielkeDaniel commented 1 year ago

Thanks for your reply I am gonna try with this one https://uiwjs.github.io/react-codemirror/

if doens't work i am gonna build my own Thanks so much!

I tried that one as well. Notice that it´s not as customizable as the standard codemirror, which isn´t too much setup in the end!

kaushikc44 commented 1 year ago

No its not , Please go through my code from here https://github.com/kaushikc44/codevim

ArchanaSharma95 commented 1 year ago

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: builder-cub@1.0.0 npm ERR! Found: react@18.2.0 npm ERR! node_modules/react npm ERR! react@"^18.2.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@">=15.5 <=16.x" from react-codemirror2@7.2.1

I'm facing the same issue. Is there any solution that worked?

kaushikc44 commented 1 year ago

Are you using uiw / code mirror module? I have already mentioned that you prefer that., since code mirror isn't yet supported for react 18.2.0 either use a older version of react or use uiw/code mirror check the above repository codevim you can find the code for it.

jaywcjlove commented 1 year ago

Thanks for your reply I am gonna try with this one https://uiwjs.github.io/react-codemirror/ if doens't work i am gonna build my own Thanks so much!

I tried that one as well. Notice that it´s not as customizable as the standard codemirror, which isn´t too much setup in the end!

@MielkeDaniel https://github.com/uiwjs/react-codemirror/tree/v3

Using v3 is the old cm5 version.

Favourz1 commented 1 year ago

Please I've been on this same issue for 2 days now is there any solution yet? I'm trying to use react-codemirror2 with peer dependency codemirror on React 18.2.0 and still haven't found a way out. I appreciate your assistance in advance!

7hourspg commented 1 year ago
  1. Turn off your react strict mode in index.js
  2. install "react-codemirror2": "^7.2.1
  3. install "codemirror": "^5.57.0"
  4. and last one use --force while you install any packages

It's worked on react v 18 for me

Favourz1 commented 1 year ago

Thanks @7hourspg.

So I'd install the dependencies with npm i react-codemirror2@7.2.1 codemirror@5.57.0 --force ??

Dhimantwalia commented 1 year ago

npm WARN using --force Recommended protections disabled. npm WARN ERESOLVE overriding peer dependency npm WARN While resolving: react-codemirror2@7.2.1
npm WARN Found: react@18.2.0 npm WARN node_modules/react npm WARN peer react@"^18.0.0" from @testing-library/react@13.4.0 npm WARN node_modules/@testing-library/react
npm WARN @testing-library/react@"^13.4.0" from the root project npm WARN 3 more (react-dom, react-scripts, the root project) npm WARN npm WARN Could not resolve dependency: npm WARN peer react@">=15.5 <=16.x" from react-codemirror2@7.2.1 npm WARN node_modules/react-codemirror2 npm WARN react-codemirror2@"7.2.1" from the root project npm WARN npm WARN Conflicting peer dependency: react@16.14.0
npm WARN node_modules/react npm WARN peer react@">=15.5 <=16.x" from react-codemirror2@7.2.1 npm WARN node_modules/react-codemirror2 npm WARN react-codemirror2@"7.2.1" from the root project

added 2 packages, and audited 1480 packages in 8s

231 packages are looking for funding run npm fund for details

7 vulnerabilities (1 moderate, 6 high)

To address all issues (including breaking changes), run: npm audit fix --force

Run npm audit for details.

@Favourz1 , I used your command, this came up but codemirror is now installed, however are these warnings concerning or should i ignore them? (PS: I am new to React)

Bhavika-Maurya commented 1 year ago
  1. Turn off your react strict mode in index.js
  2. install "react-codemirror2": "^7.2.1
  3. install "codemirror": "^5.57.0"
  4. and last one use --force while you install any packages

It's worked on react v 18 for me

Thank you @7hourspg , it worked for me in React v18

ajay-nishad25 commented 11 months ago

hey @7hourspg , thanks buddy for helping

khamkaradinath commented 11 months ago

working