scniro / react-codemirror2

Codemirror integrated components for React
MIT License
1.65k stars 192 forks source link

Support React 18 as a peer dependency #312

Closed fongandrew closed 2 months ago

fongandrew commented 2 months ago

The immediate goal of this PR is to bump the peer dependency of this to support React 18. Per https://github.com/scniro/react-codemirror2/issues/293 (and as far as I can tell), it shuld work.

But the build dependencies and CI integration for this package are very out of date, so we had to update a whole bunch of other things just to get here.

https://github.com/scniro/react-codemirror2/assets/179327/9ec46c1f-7e86-476a-b35f-3a69ff07c01c

As part of this PR, we also bump the package version to v8. It technically shouldn't be necessary for a major version bump just to support React 18, but this integration is sort of undertested with v18. So we're doing a major version bump to force folks to explicit bump what they have rather than just bringing it in by default and maybe seeing things subtly breaking unexpectedly.