scniro / react-codemirror2

Codemirror integrated components for React
MIT License
1.66k stars 193 forks source link

Object.assign doesn't work by default in Internet Explorer #76

Closed anandsainath closed 6 years ago

anandsainath commented 6 years ago

We use Object.assign in the following line - https://github.com/scniro/react-codemirror2/blob/3250f5833f48e65a1b560dc3059f0ce4ed0771fd/src/index.tsx#L616

Unfortunately, Internet Explorer doesn't have a definition for the same. And its very difficult to override object.assign from an external module :(

Can we depend on an external library (like core-js) to get the definition for assign and use that instead?

scniro commented 6 years ago

@anandsainath Are you using webpack/babel? I suppose I can add a polyfill, but it feels so... gross. I'll keep you posted with if I add anything but I definitely think you can handle this through a bundler.

scniro commented 6 years ago

@anandsainath fixed with the 4.3.0 release

anandsainath commented 6 years ago

@scniro Thank you! :)