search

scoder / fastrlock

A fast RLock implementation for CPython
MIT License
23 stars 10 forks source link

Add linux aarch64 wheel build support #13

Closed odidev closed 2 years ago

odidev commented 3 years ago

Add linux aarch64 wheel build support.

Related to https://github.com/scoder/fastrlock/issues/12 @scoder Could you please review this PR?

scoder commented 3 years ago

lxml already has a better Makefile implementation that avoids duplicating the entire build script:

https://github.com/lxml/lxml/blob/5c8edfa39b0e31490a581740aaff44656ec72348/Makefile#L61-L65

Could you try to adapt that?

That said, I'd rather not run that build locally on my machine since the emulation makes it horribly slow. Would be nice to have Github Actions do it for me.

odidev commented 3 years ago

@scoder I have done the changes as per your suggestions. Please take a look.

odidev commented 2 years ago

@scoder, could you please review this PR? Thanks.

scoder commented 2 years ago

How very nice! Thanks!

odidev commented 2 years ago

@scoder, may I know the plan for releasing AArch64 wheels? Thanks.

kmaehashi commented 2 years ago

Great work, @odidev! I'm also interested in the aarch64 wheel availability as I'm planning to release CuPy wheels for aarch64.

scoder commented 2 years ago

I'll push them out as soon as I have everything up and running. During the next days.

Looks like the PGO build is failing for aarch64, probably due to resource problems on the virtual machine. I'll see if I can reduce the benchmark run overhead.

scoder commented 2 years ago

It also seems worth building the wheels in separate GHA matrix jobs. Especially the AArch64 wheels take very long to build in the end.