search

scoin / multichain-node

A simple wrapper for Multichain's JSON RPC api that parses your input.
MIT License
73 stars 54 forks source link

Fix issue #26 #27

Closed gvko closed 6 years ago

gvko commented 6 years ago

Update 'start' argument to equal the negative value of the passed 'count' value when the passed arguments are in the form of an object.

scoin commented 6 years ago

Hi @galioy, thanks for your contribution and for bringing this issue to my attention.

Unfortunately I cannot accept this pull request. While Multichain's spec has become stable since 1.0 it was historically sort of a moving target since first publishing this repo. I imagine things will continue to change and as a result, It would not be prudent to have a special case just for count in the parser logic.

However, I have fixed the issue in 2a3bdc782a83bc199c55b0ad92e1d84f5b2e1e16 and 4519ac5426fe53802beeb52ef1d4a182ddc9790d which are represented in version 2.2.0-version1.0.4, now available in npm.