scoin / multichain-node

A simple wrapper for Multichain's JSON RPC api that parses your input.
MIT License
73 stars 54 forks source link

Not all parameters exposed in signrawtransaction #5

Closed davidiluvatar closed 7 years ago

davidiluvatar commented 7 years ago

Hello! Not really sure why you would have intentionally left it out, but I can see that while multichain-cli implements:

signrawtransaction tx-hex ( [{"txid":"id","vout":n,"scriptPubKey":"hex","redeemScript":"hex"},...] ["privatekey1",...] sighashtype )

multichain-node/lib/commands.js only the first parameter:

signRawTransaction: ["hexstring"]

I have had to change commands.js in this way:

signRawTransaction: ["hexstring", "scripts", "privatekeys"]

Now I can sign raw transactions with private keys not in the wallet.

scoin commented 7 years ago

whoops, must have overlooked this. Want to submit PR?

scoin commented 7 years ago

aa878fe0d14c3dca838d934992690bd736ad08b2