search

scolby33 / pushover_complete

A Python package for interacting with *all* aspects of the Pushover API.
MIT License
6 stars 5 forks source link

image attachment support #5

Closed fracai closed 6 years ago

fracai commented 6 years ago

Pushover today added support for image attachments. This PR adds support for specifying the path to an image when calling send_message.

send_message(…, image_path="/path/to/the/image")

codecov-io commented 6 years ago

Codecov Report

Merging #5 into develop will decrease coverage by 3.96%. The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #5      +/-   ##
===========================================
- Coverage      100%   96.03%   -3.97%     
===========================================
  Files            3        3              
  Lines          100      101       +1     
  Branches         7        8       +1     
===========================================
- Hits           100       97       -3     
- Misses           0        3       +3     
- Partials         0        1       +1
Impacted Files Coverage Δ
src/pushover_complete/pushover_api.py 95.34% <55.55%> (-4.66%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9c15f3...d15f584. Read the comment docs.

cthoyt commented 6 years ago

Cool PR, @fracai. Excited to hear your feedback on my comments

fracai commented 6 years ago

Thanks, I've been asking for images to be supported for a while now and was excited to see that they've turned it on. I'm using your library to push ZoneMinder alerts and this makes them much more useful. I should be able to get to these changes this evening.

scolby33 commented 6 years ago

Also @fracai add yourself to AUTHORS.rst too!

scolby33 commented 6 years ago

Superseded by #9