search

scolby33 / weather_kindle

Use your Kindle to display a weather forecast!
Other
30 stars 4 forks source link

World Meterological Organization method does not work #2

Closed vladime closed 3 years ago

vladime commented 3 years ago

I have used city_id 58 for WMO in the config file but unfortunately kindle returns "error.png" picture. I have kindle 4. All other methods are working fine. Have you tested WMO method on your K4?

scolby33 commented 3 years ago

I have validation in the code that requires WMO city id's to be 3 or 4 characters long. I must have missed that they can possibly be only two digits. Let me check on this and push a fix.

scolby33 commented 3 years ago

Yep! I actually made a couple mistakes here with the WMO configuration. I've opened a PR at #3 with a fix that works for me, but it'd be great if you could test this build as well. I've made installer and uninstaller updates for the branch and attached them here. Can you try this out on your Kindle and let me know how it works? It's safe to install the update over your existing installation.

Update_weather_k4_wmo_parsing_improvements.zip

vladime commented 3 years ago

Thank for the prompt response and a quick fix! I had to uninstall existing version to have a clean test for "Update_weather_k4_wmo_parsing_improvements.zip" version. Now WMO option works but only with "Imperial" units. As soon as I enable "Metric" option in config file I get error page on the screen.

scolby33 commented 3 years ago

🤦 I made a second silly mistake in fixing the first one. Here's another build to try. Update_weather_k4_wmo_parsing_improvements.zip

vladime commented 3 years ago

METRIC="1" CITY_ID="58"

This my weather_config.sh file. The output is still imperial (F) not metric (C).

scolby33 commented 3 years ago

You're right, turns out WMO metric output was never working. Yet another test build :)

Update_weather_k4_wmo_parsing_improvements.zip

vladime commented 3 years ago

After the test:

scolby33 commented 3 years ago

Oh, I guess I jumped too quickly. Let's open a new one and I'll be able to look at it later tonight :)

scolby33 commented 3 years ago

Oh, I screwed up by not fully pushing a branch. #6 should fix it, give me a few minutes to cut a new release.