scolladon / sfdx-git-delta

Generate the sfdx content in source format from two git commits
Other
444 stars 115 forks source link

SGD Not Adding All Changed Tableau Components to Package.xml #218

Closed ninja-momma closed 2 years ago

ninja-momma commented 2 years ago

Issue verification check :

What is the problem

SGD is not adding all of the changed Tableau components to the package.xml file. Below is the log from our Jenkins build:

+ ls -R changed_sources/force-app
changed_sources/force-app/main/default:
wave

changed_sources/force-app/main/default/wave:
EM_Utilization_comp.wcomp
EM_Utilization_comp.wcomp-meta.xml
Utilization_Dashboard.wdash
Utilization_Dashboard.wdash-meta.xml
Utilization_component.wcomp
Utilization_component.wcomp-meta.xml

reviewing deployment package.xml
[Pipeline] sh
+ cat changed_sources/package/package.xml
<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>Utilization_Dashboard</members>
        <name>WaveDashboard</name>
    </types>
    <version>52.0</version>
</Package>

What is parameter and their value you used

sfdx sgd:source:delta --to HEAD --from d6f7937b68cc90c3b182c3c008601e1abcaa0e9c --output changed_sources --generate-delta --ignore .forceignore_deployment

What is the expected result

<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>Utilization_Dashboard</members>
        <name>WaveDashboard</name>
    </types>
    <types>
       <members>EM_Utilization_comp</members>
       <members>Utilization_comp</members>
       <name>WaveComponent</name>
    </types>
    <version>52.0</version>
</Package>

What is the actual result

<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>Utilization_Dashboard</members>
        <name>WaveDashboard</name>
    </types>
    <version>52.0</version>
</Package>

Only the Utilization_Dashboard was deployed.

Steps to reproduce

linux-x64

node-v17.1.0

git version 2.11.0

sfdx-cli/7.112.1

sgd plugin version: 4.8.1

scolladon commented 2 years ago

Hi @ninja-momma !

Thanks for raising this issue and for helping this plugin to be better !

This metadata is not added in our internal metadata repository, this is why it is not treated.

I had a quick look at the metadata api documentation and I have not been able to find it there (I looked from 53.0 to 40.0...) !

Do you know where I can find it so I can include it ? Or do you know how it behave:

Thanks !

ninja-momma commented 2 years ago

Yes, this metadata is not documented. I came across it in this post: https://www.salesforceblogger.com/2020/06/15/uncovering-deployment-techniques-for-einstein-analytics/

You can find it when entering "WaveComponent" in the search field for the Metadata Coverage Report (https://developer.salesforce.com/docs/metadata-coverage/53). Unfortunately this is no documentation.

We tested a retrieval and deployment with it in the package.xml and it worked.

Here is information about the component:

scolladon commented 2 years ago

Awesome, that's a great contribution, thank you very much.

I think there are couple of other metadata types that we should also include based on the content of the blog (DiscoveryAIModel and DiscoveryGoal)

We will create a new version integrating this very soon

Stay tuned

ninja-momma commented 2 years ago

Thank you so much! This plugin is a fantastic tool!

scolladon commented 2 years ago

New version (4.12.0) available !