scolladon / sfdx-git-delta

Generate the sfdx content in source format from two git commits
Other
414 stars 112 forks source link

fix: apply ignore settings when copying file #745

Closed scolladon closed 8 months ago

scolladon commented 8 months ago

Explain your changes


Ensure ignore service is called when copying files

Does this close any currently open issues?


closes #744

scolladon commented 8 months ago

Could you help us with the end user testing @mmindenhall please ?

You can follow those steps to install the plugin from this PR locally

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@d5974f2). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #745 +/- ## ======================================== Coverage ? 100.00% ======================================== Files ? 35 Lines ? 997 Branches ? 100 ======================================== Hits ? 997 Misses ? 0 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 8 months ago

Code Climate has analyzed commit 526cc300 and detected 0 issues on this pull request.

View more on Code Climate.

mmindenhall commented 8 months ago

Hi @scolladon,

Apologies for the delayed reply...I was on vacation all of last week. I just did the following to verify your fix:

  1. Followed your instructions to install the plugin from this PR branch
  2. Re-ran the command I posted in #744 against my fork of the sfdx-git-delta-reproduction-playground
  3. Verified that the __tests__ folder and its contents are no longer copied to the plugin output folder

Thanks!

scolladon commented 8 months ago

Thanks for your contribution on validating the fix @mmindenhall

github-actions[bot] commented 8 months ago

Shipped in release v5.32.0. You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.32.0

Happy incremental deployment!