search

scolladon / sfdx-git-delta

Generate the sfdx content in source format from two git commits
Other
414 stars 112 forks source link

feat: resolve metadata type using file extension #750

Closed scolladon closed 7 months ago

scolladon commented 8 months ago

Explain your changes

Allow to resolve metadata type using the file extension instead of the folder when possible.

Fallback is to use the folder extension for those types:

Does this close any currently open issues?

closes #642 #350

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e324f00) 100.00% compared to head (43792fa) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #750 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 36 37 +1 Lines 1003 1021 +18 Branches 100 104 +4 ========================================= + Hits 1003 1021 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scolladon commented 8 months ago

Hi @fedegiust, @jverelst & @jjulicher !

We have a first working implementation of the metadata detection based on the extension first !

Could you please help us in validating this feature ?

If you are interested in the spec it is written here. If you think we can add more cases feel free to suggest !

The code currently handles all the special cases we have found so far. Even the one when we have the same extension but not the same metadata type because it is not contained in the same folder (one of the most tricky to make work with all the other cases)

In order to test it locally, you can follow those steps and install this PR.

Let us know, we will merge it soon and ship a new release asap

codeclimate[bot] commented 7 months ago

Code Climate has analyzed commit 43792faa and detected 0 issues on this pull request.

View more on Code Climate.

github-actions[bot] commented 7 months ago

Shipped in release v5.35.0. You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.35.0

Happy incremental deployment!