search

scolladon / sfdx-git-delta

Generate the sfdx content in source format from two git commits
Other
436 stars 115 forks source link

fix: type detection of `EmailServicesFunction` #831

Closed scolladon closed 5 months ago

scolladon commented 5 months ago

Explain your changes

Flag EmailServicesFunction type to be detected only via directory. As its file extension is too broad and this type cannot be located outside its folder

Does this close any currently open issues?

closes #830

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (de4cc73) to head (31b5c58).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #831 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 37 37 Lines 1041 1042 +1 Branches 113 113 ========================================= + Hits 1041 1042 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codeclimate[bot] commented 5 months ago

Code Climate has analyzed commit 31b5c58c and detected 0 issues on this pull request.

View more on Code Climate.

scolladon commented 5 months ago

Hi @Enszula @bhushanpuri1991 @Sero030 !

Could you help with the QA of this PR please ? It attempts to fix the issue with EmailServicesFunction type detection. You can try locally following those steps

Help will be very much appreciated here :) I'll merge it and ship a new release as soon as it is validated

github-actions[bot] commented 5 months ago

Shipped in release v5.38.3. You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.38.3

Happy incremental deployment!