search

scolladon / sfdx-git-delta

Generate the sfdx content in source format from two git commits
Other
402 stars 110 forks source link

Consider file with extension ".md" as CustomMetadata #853

Closed camillerev closed 2 months ago

camillerev commented 2 months ago

Issue verification check:

What is the problem?

The files with the extension ".md" are considered as CustomMetadata components. After we run the sgd command with new .md files, we find it in the package.xml as below: image

What is the parameter and the value you used with it?

Here is the command ran: sf sgd:source:delta --to HEAD --from origin/main --repo . --output . --api-version 60.0

What is the expected result?

Not having the files with the extension ".md" in the package.xml when we run the sgd command.

What is the actual result?

The files with the extension ".md" are considered as CustomMetadata components in the package.xml. Here is an example: image

Steps to reproduce

  1. Use the repo : https://github.com/camillerev/sfdx-delta-error-reproduction
  2. Run : git checkout feature/testCustomMetadataPackage sf plugins install sfdx-git-delta sf sgd:source:delta --to HEAD --from origin/main --repo . --output . --api-version 60.0
  3. Check the new file: package.xml The file should not contain README and TEST. (Those are corresponding to ./TESTMD/README.md and ./TEST.md files that I created on the branch to test)

Result: The package.xml contains: image

Execution context

Operating System: MacOs 14.4.1

yarn version: …

node version: v21.6.1

git version: git version 2.30.2

sfdx version: salesforce/cli/2.25.7

sgd plugin version: v5.38.4

More information (optional)

scolladon commented 2 months ago

Hi @camillerev !

This issue has been fixed and is released with the version v5.39.1 (available with the channel latest-rc Could you try this version ? (sfdx plugins:install sfdx-git-delta@latest-rc)

If it is ok for you we will make the latest channel target the v5.39.1 !

Thanks !

camillerev commented 2 months ago

Hi @camillerev !

This issue has been fixed and is released with the version v5.39.1 (available with the channel latest-rc Could you try this version ? (sfdx plugins:install sfdx-git-delta@latest-rc)

If it is ok for you we will make the latest channel target the v5.39.1 !

Thanks !

Indeed, I just tested and it works well with the latest-rcchannel! Thanks @scolladon!

scolladon commented 2 months ago

You're welcome !

Happy incremental deployment 🚀