scolladon / sfdx-git-delta

Generate the sfdx content in source format from two git commits
Other
402 stars 110 forks source link

fix: metadata type detection for subtype not packageable contained inside file #858

Closed scolladon closed 2 months ago

scolladon commented 2 months ago

Explain your changes


Make sure the plugin detects subtype and copy the file when not packageable subtype are present after pruning a file

Does this close any currently open issues?


closes #857

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (5941fcd) to head (988b051).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #858 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 39 39 Lines 1069 1067 -2 Branches 115 114 -1 ========================================= - Hits 1069 1067 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scolladon commented 2 months ago

Hi @jfaderanga !

Could you help here and test the fix with the exact context you used to experience the related issue please ?

You can follow those steps to install the dev version locally and test it.

codeclimate[bot] commented 2 months ago

Code Climate has analyzed commit 988b051d and detected 0 issues on this pull request.

View more on Code Climate.

jfaderanga commented 2 months ago

Hi @jfaderanga !

Could you help here and test the fix with the exact context you used to experience the related issue please ?

You can follow those steps to install the dev version locally and test it.

Hi @scolladon thanks heaps mate, I've tested both latest and dev in the exact context where we get the issue. @latest - failed, package xml is empty. @dev-858 - passed, package xml is not empty.

github-actions[bot] commented 2 months ago

Shipped in release v5.39.2. You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.39.2

Happy incremental deployment!