Getting `Could not find` error when generating delta source

kez-sophos commented 4 months ago

Issue verification check:

[X] is the current repository fully deployable at the commit SHA provided with the 'from' parameter of the command?

What is the problem?

We are getting an error when trying to generate delta source with sfdx-git-delta versions above 5.34.0.

What is the parameter and the value you used with it?

sgd source delta --to HEAD --from stash/master --source C:\ --api-version 59.0 --output C:\\delta-src/ --generate-delta

What is the expected result?

Delta source generation succeeds.

What is the actual result?

Delta source generation fails. Json Response: {"success":false,"error":"Could not find b2c43ed8d669af3b0af194a54362238c0ed66de5.","output":"C:\\delta-src/","warnings":[]}

Steps to reproduce

We are unable to reproduce the issue locally (within our machines) the issue is occurring within our build servers.

Execution context

Within our build servers we use Bamboo and Windows 2012. Operating System: Windows 2012

yarn version: N/A

node version: v18.12.0

git version: git version 2.29.2.windows.3

sfdx version: @salesforce/cli/2.40.7 win32-x64 node-v20.12.2

sgd plugin version: sfdx-git-delta 5.39.2 (5.39.2)

kez-sophos commented 4 months ago

To clarify, sfdx-git-delta version 2.34.0 works as expected for us. We encounter this issue with later versions.

scolladon commented 4 months ago

Hi @kez-sophos !

Thanks for raising this issue and thanks for contributing in making this project better!

We are aware of this issue already, it has been discovered with the #762 But we are not able to reproduce it locally so we cannot fix it yet. I tried a lot of things (VM, etc) without success.

You are right, the issue is not there with the v5.34.0 (current stable channel) because after this point we have refactored the way we interact with git. After that point we are using isomorphic-git to abstract and speed up the interaction with git. Unfortunately it has some issues with windows, especially with very large and aged repository...

Do you have a way to reproduce the issue I could use with a VM ?

scolladon commented 4 months ago

Hi @kez-sophos, do you have any way to help me reproduce the issue ?

scolladon commented 4 months ago

Hi @kez-sophos I need your help to reproduce please, could you send us the minimal steps to follow to reproduce it please ?

ALesc21 commented 1 month ago

we also get the issue with sfdx-git-delte version 5.42.0 on our build servers and if we downgrade to the vertion 5.43.0 then the package creation is working again but with the older API version 59.0

OS: MS Windows Server 2019 node version: 20.11.1 git vertion: git version 2.44.0.windows.1 sf version: @salesforce/cli/2.53.6 win32-x64 node-v20.11.1

on my local machine Windows 11 and pretty similar versoins the issue is not appearing

any ideas what could be the cause of the problem?

scolladon commented 1 month ago

Thanks for those information. It really helps

What api version are you using ? 61 ? And what version of sgd is working ? (5.43.0 does not exist yet)

ALesc21 commented 1 month ago

hi @scolladon,

we try or have to use the api vesion 61 because some implementations already requires it.

sorry that was a number mix-up. So the sgd version 5.42.0 is not working then we downgraded to 5.34.0 like "[kez-sophos]" wrote and it start to work without issue

scolladon commented 1 month ago

This issue is very hard because it is windows dependent and also requires a very big project. If you can give me access to your project where you reproduce the issue it will greatly help reproducing and see what happens. I suspect the issue comes from a library we are using that need to be patched, but no customers so far have been able to provide a complete reproduction scenario working on my machine 😪 I can sign NDA, or anything if necessary

ALesc21 commented 1 month ago

hi @scolladon, I will not be available for some days but afterwards maybe we can plan a session for screen sharing and check together.

scolladon commented 1 month ago

That's nice of you @ALesc21 to give a bit of your time but it is very hard to investigate with a screen share and a limited amount of time. We tried already with another person and we did not manage to find the root cause. I would really feel more confident if I can reproduce the issue on my laptop

scolladon / sfdx-git-delta