scolladon / sfdx-git-delta

Generate the sfdx content in source format from two git commits
Other
445 stars 114 forks source link

feat: add FeatureParameter metadata support #915

Closed aljaz823 closed 2 months ago

aljaz823 commented 2 months ago

Explain your changes


Add metadata support for all three types of Feature Parameters:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (5562561) to head (7675772). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #915 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 40 40 Lines 1083 1083 Branches 115 115 ========================================= Hits 1083 1083 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aljaz823 commented 2 months ago

Nice addition, thanks !!!

Could the definition be at the top of the file ? Also, has it been tested manually ?

Sure, I moved definitions to the top of metadata files.

It has been tested manually, here is the result.

Feature parameters of all three different types:

image

Generated diff package.xml file:

<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>FeatureBoolean1</members>
        <name>FeatureParameterBoolean</name>
    </types>
    <types>
        <members>FeatureDate1</members>
        <name>FeatureParameterDate</name>
    </types>
    <types>
        <members>FeatureSet1</members>
        <members>FeatureSet2</members>
        <name>FeatureParameterInteger</name>
    </types>
    <version>60.0</version>
</Package>
codeclimate[bot] commented 2 months ago

Code Climate has analyzed commit 76757724 and detected 0 issues on this pull request.

View more on Code Climate.

aljaz823 commented 2 months ago

I added the integration tests, though I'm not familiar with that so I just followed the other patterns. Let me know if it needs additional fixing.

github-actions[bot] commented 2 months ago

Shipped in release v5.44.0. You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.44.0

Happy incremental deployment!