scolladon / sfdx-git-delta

Generate the sfdx content in source format from two git commits
Other
445 stars 114 forks source link

BriefcaseDefinitions metadata not handled by plugin #925

Closed camillerev closed 1 month ago

camillerev commented 1 month ago

Issue verification check:

What is the problem?

The metadata briefcaseDefinitions doesn't seem to be handled. After we run the sgd command with new briefcaseDefinition, we don't find it in the package.xml:

image image

What is the parameter and the value you used with it?

Here is the command ran: sf sgd:source:delta --to HEAD --from origin/main --repo . --output . --api-version 61.0

What is the expected result?

The briefcaseDefinitions should be in the package.xml

image

What is the actual result?

The briefcaseDefinitions is not in the package.xml

Steps to reproduce


Use the repo : https://github.com/camillerev/sfdx-delta-error-reproduction Run : git checkout test/briefcaseInDelta sf plugins install sfdx-git-delta sf sgd:source:delta --to HEAD --from origin/main --repo . --output . --api-version 61.0 Check the new file: package.xml The briefcaseDefinitions should be in the package.xml

Result: The package.xml contains:

image

Execution context


Operating System: 14.6.1

yarn version:

node version: v21.6.1

git version: git version 2.30.2

sfdx version: @salesforce/cli/2.42.6 darwin-x64 node-v20.12.2

sgd plugin version: v5.45.0

More information (optional)

scolladon commented 1 month ago

Hi @camillerev !

Thanks for raising this issue and thanks for contributing in making this project better!

I'll ship it soon, stay tune !

github-actions[bot] commented 1 month ago

Shipped in release v5.46.0. You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.46.0

Happy incremental deployment!