sconover / wrong

Wrong provides a general assert method that takes a predicate block. Assertion failure messages are rich in detail.
MIT License
434 stars 31 forks source link

1.9.3-p0 compatibility #15

Closed thenrio closed 12 years ago

thenrio commented 12 years ago

Hello I found ill behavior with mri-1.9.3-p0

~/src/ruby/wrong [master]$ ruby test/config_test.rb ruby 1.9.3p0 (2011-10-30 revision 33570) [x86_64-darwin10.8.0] /Users/thenrio/.rbenv/versions/1.9.3-p0/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in require': cannot load such file -- ParseTree (LoadError) from /Users/thenrio/.rbenv/versions/1.9.3-p0/lib/ruby/1.9.1/rubygems/custom_require.rb:36:inrequire' from /Users/thenrio/src/ruby/wrong/lib/wrong/chunk.rb:7:in require_optionally' from /Users/thenrio/src/ruby/wrong/lib/wrong/chunk.rb:13:in<top (required)>' from /Users/thenrio/.rbenv/versions/1.9.3-p0/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in require' from /Users/thenrio/.rbenv/versions/1.9.3-p0/lib/ruby/1.9.1/rubygems/custom_require.rb:36:inrequire' from /Users/thenrio/src/ruby/wrong/lib/wrong/assert.rb:5:in <top (required)>' from /Users/thenrio/.rbenv/versions/1.9.3-p0/lib/ruby/1.9.1/rubygems/custom_require.rb:36:inrequire'

WDYT?, Thierry

thenrio commented 12 years ago

So what about now ? Curious and glad you reviewed this PR :)

alexch commented 12 years ago

Been too busy to dig into it. I tried installing 1.9.3rc1 via RVM and got the dreaded readline library problem and haven't had time to try again since.

On Wed, Nov 16, 2011 at 12:12 PM, Thierry Henrio reply@reply.github.com wrote:

So what about now ? Curious and glad you reviewed this PR :)


Reply to this email directly or view it on GitHub: https://github.com/sconover/wrong/pull/15#issuecomment-2767180

Alex Chaffee - alex@cohuman.com - http://alexch.github.com Stalk me: http://friendfeed.com/alexch | http://twitter.com/alexch | http://alexch.tumblr.com

thenrio commented 12 years ago

Fun!

I took opportunity of 1.9.3-p0 to try rbenv... and had some other dreadful issues :)

(https://github.com/sstephenson/rbenv/issues/89 and gem pristine rake (or gem pristine rails...))

tjschuck commented 12 years ago

Looks like this was fixed by 62ef049b9a73ad9f85e98325a0d975dd54da9409

alexch commented 12 years ago

@tjschuck true dat