search

sconover / wrong

Wrong provides a general assert method that takes a predicate block. Assertion failure messages are rich in detail.
MIT License
434 stars 31 forks source link

Plug require_optionally for a random change in the error message style for 1.9.3p0 #18

Closed kyledrake closed 12 years ago

kyledrake commented 12 years ago

The fact that this changed at some point from "no such file to load" to "cannot load such file" is exactly what the term "turd polishing" was invented for.

Could you push this to a new gem version pretty plz? It's breaking my travis CI for 1.9.3.

szymon-jez commented 12 years ago

+1

kyledrake commented 12 years ago

Any traction on this? It's still an issue with 1.9.3 (checked p0 and latest)

kyledrake commented 12 years ago

If it's not adequate let me know and I can refactor it as well. Thanks!

kyledrake commented 12 years ago

It's also important to comment that the way this is written, it's really not easy to overload it to fix the problem. It might make sense to change it to be within the module of the project, and not as a global method.

tjschuck commented 12 years ago

Looks like this was fixed by 62ef049b9a73ad9f85e98325a0d975dd54da9409

alexch commented 12 years ago

yep, it should work as of March or so (v0.6.2). @kyledrake could you please confirm?

kyledrake commented 12 years ago

Yeah it should be G2G, I'll close this.