search

scooterhacking / NinebotCrypto

An implementation of the NinebotCrypto protocol by majsi.
GNU Affero General Public License v3.0
42 stars 15 forks source link

WIP: Add TypeScript implementation #5

Closed 0x77dev closed 1 year ago

0x77dev commented 3 years ago

Work in progress

Created a PR to get some suggestions about the code currently on testing stage

bastianpedersen commented 3 years ago

Looks good to me, but we need to wait for Charles to take a look at it. Have you tested the implementation to see if it works?

nopbxlr commented 3 years ago

@bastiantangedal I am not familiar with TypeScript - I'll leave opinions to others.

bastianpedersen commented 3 years ago

@nopbxlr Looks like we're in the same boat then. I guess the only thing to do is to test the implementation, though I do not know how. Maybe an Electron-app would be sufficient?

majsi commented 3 years ago

I can do a formal review

0x77dev commented 3 years ago

@majsi that would be great!

There are some troubles with the encrypt method will fix this week.

0x77dev commented 3 years ago

@bastiantangedal I currently implementing the daemon with HTTP/WS API on Node.js

majsi commented 3 years ago

@majsi that would be great!

There are some troubles with the encrypt method will fix this week.

please let me know when you fix it. Thanks :)

0x77dev commented 2 years ago

Hey guys, it's been a long week year.

I no longer have access to a scooter; can someone provide samples of communications to verify it is working?

Just encrypt/decrypt the sequence to test it.

0x77dev commented 1 year ago

Hey guys, it's been a long week year.

I no longer have access to a scooter;

can someone provide samples of communications to verify it is working?

Just encrypt/decrypt the sequence to test it.

Is there any update?

Can someone please share communication log to test cryptography?

bastianpedersen commented 1 year ago

I thought you got what you needed using miauth?