search

scooterpsu / Comixology_Ubooquity_2

38 stars 7 forks source link

new v2 main comic/publisher html and css example/file? #23

Closed CuddleBear92 closed 4 years ago

CuddleBear92 commented 4 years ago

Could we get a new v2 main comic/publisher html and css example/file?

Half the time the featured publisher doesn't load. Tried playing with it, removing uneeded parts and such and it doesnt make it better. These files worked fine IIRC in v1.

Thinking about it, its prob the css that needs correcting on the placement. But having the featured publishers not loading every time is not sounding good or stable.

Attached zip of the old v1 file as ref at the bottom. unknown

Comics-publisher-html-css.zip

scooterpsu commented 4 years ago

The issue is that v2 doesn't need a publisher page anymore, that's created by the skin itself. You just need to set your base comic ID in the settings json (yours is 1 from the screenshot), and it does the rest. Your publisher html is directly conflicting with the skin, causing the above

CuddleBear92 commented 4 years ago

I see. I don't have a settings json i believe. Only jsons i find examples of is the series ones. Could i get an example?

scooterpsu commented 4 years ago

Sorry, settings.js, It has to be there or the skin wouldn't be loading.

CuddleBear92 commented 4 years ago

Ok, thanks, found it. Interesting. Really should be a wiki to cover these things :D

scooterpsu commented 4 years ago

I mean searching the linked forum thread has some of these answers. It's linked in on the git readme page with the bold line mentioning the settings.js . :)

scooterpsu commented 4 years ago

You need to set the comicsBaseID in settings.js so it knows what page is your publisher page. From your screenshots, that should be 1.

var comicsBaseID=null; should become var comicsBaseID=1;

And sure, a better set of documentation is nice to have. But when linked to a source where people have asked the questions you have, it's nice to be able to Ctrl+F and see if there's already an answer.