search

scopatz / w3g

Access Warcraft 3 replay files from Python 2 or 3
Creative Commons Zero v1.0 Universal
45 stars 16 forks source link

Wrong winner detected #11

Closed kungfoolfighting closed 4 years ago

kungfoolfighting commented 4 years ago

Hello,

I am having an issue with the winner detection. Lady Risa replay tool detects the correct winner, but this lib detects the wrong winner. This is the example replay: replay Winner should be player Tapion, but at least in my tests the lib detects the wrong winner.

Is this something that could be fixed anytime soon?

scopatz commented 4 years ago

I'll try to find some time to take a look, but it would be helpful if we knew what the underlying issue is.

SantoDE commented 4 years ago

Hey @scopatz,

I tried to figure it out as well. It looks strange to me. It looks like, as if there is no proper leave event and thus, the lib considers the wrong player as a winner. But im unsure. Maybe we can pair on that?

scopatz commented 4 years ago

Yeah, I think that is true, IIRC. PRs very welcome here

SantoDE commented 4 years ago

Cool! Any hints on how to tackle it?

SantoDE commented 4 years ago

Update: I digged a lot deeper and figured, that "result()" is incorrectly reporting "lost" for the player who won. But from here, its very tight to the actual w3g format where im not that confident in...

Edit @scopatz if you have any ideas based on my recent findings, just shoot (= You probably know more than I do!