search

scopatz / w3g

Access Warcraft 3 replay files from Python 2 or 3
Creative Commons Zero v1.0 Universal
42 stars 16 forks source link

Not updated to be compatible with replays of version 1.32 yet? #16

Open lukas2342 opened 2 years ago

lukas2342 commented 2 years ago

I just tried to open the replay from https://warcraft3.info/replays/59360 by cloning and running the exact code from readme.rst. Unfortunately I got a UnicodeDecodeError. I guess that's due to your code not being updated to the latest wc3 version yet? Is it still being maintained?

debaser19 commented 2 years ago

also running into the same. appears it hasn't been updated for 1.32. dev hasn't updated since 2020 so i don't think this project is still alive, unfortunately

manh4wk commented 1 year ago

It looks like Blizzard changed how they're storing some of the reforged player metadata (player id number, battle tag, clan, portrait, and maybe more) with patch 1.32.10. I'm not seeing the clan information in it anymore, but it looks like they may have added in the portrait ID? I can't change my portrait in WC3 to test it out for some reason, is that functionality broken right now? I also haven't looked much at how patches 1.33 and 1.34 impact it, and we've got 1.35 right around the corner.

The w3gjs package handled this update by using a protobuff serializer with a given schema. I tried running some replays through it though, and it doesn't look like it's picking up all the information that's there.

I guess getting this working will entail looking at that particular segment of the replays byte by byte for all the patches from 1.32.10 forwards, and coding up whatever variations appear. I don't know if Bnet replays will have different info in them than other games too, like Warcraft 3 Champions. This will take a bit to sift through.