Closed olegakbarov closed 5 years ago
Hi @olegakbarov! Thanks for reporting. I think the must have added a new mode with v1.30
Do you know what new mode they added was?
Was not able to find anything about new mode in patch notes... 😔
yeah, me neither
This is the same thing that happened in 1.29. (see #2 ) I think, that the value for the mode has moved to another position and we are getting useless values here. For now I have found: 0x70 (112), 0x98 (152), 0xD8 (216).
Since there are no new modes I think that the position of the mode just has changed.
My solution at the moment is that I removed the line were we read the select_mode.
Oh cool, i will give it a closer look!
@hhllcks commenting out helped! ✨
I think if we did something like SELECT_MODES.get(b2i(data[offset]), 'unknown mode')
would be a good temporary fix. A pull request for this would be great!
Confirmed that commenting out self.select_mode = SELECT_MODES[b2i(data[offset])]
works as a temp fix in w3g.py for 1.30 replays.
Thanks for this project!
Not sure if this is due to 1.30 patch, but i got this error:
Any ideas what it might be caused by?