search

scope3data / methodology

Measurement methodology for advertising emissions
https://methodology.scope3.com
Apache License 2.0
29 stars 10 forks source link

digital-audio quality_impressions_per_duration_s update #136

Closed pymble2073 closed 8 months ago

pymble2073 commented 8 months ago

updated quality_impressions_per_duration_s for digital-audio to match streaming-video.

james-a-rob commented 8 months ago

@pymble2073 I took a look at this for you. I discovered that a validation test was failing and that causes this PR to say some checks not passed. 

The fix was to update the quality_impressions_per_duration_s fields in the templates/property/digital-audio.yaml file rather than the defaults/property-defaults.yaml file. The default directory is autogenerate and we have an automatic test in the build pipeline to check its never manually updated.



This changed also made a python unit test fail so updated that too.

This PR is looking good now from my POV. Able to get a review @EmmaLouise2018. FYI this is my first code change to the repo so let me know if theres any process ive not followed correctly.