scope3data / methodology

Measurement methodology for advertising emissions
https://methodology.scope3.com
Apache License 2.0
29 stars 10 forks source link

fix: fix kb conversion and clarify kb per imp #193

Closed LinguoMalkavian closed 2 months ago

LinguoMalkavian commented 2 months ago

This PR includes three changes to make sure the methodology is consistent:

  1. Correct the conversion rate of bytes to kb (was using the kib conversion) basically change 1024 to 1000 in all conversions
  2. Calculate bytes_per_imp directly from bytes_per_session and imps_per_session for clarity (old method was confusing because it went all the way to bytes_per_session_sec just to divide by secs again, this is what had resulted in the bug we saw this morning)
  3. Add embodied network emissions to the data transfer emissions for ad selection