search

scopely-devops / skew

Apache License 2.0
242 stars 70 forks source link

Update tags_spec for DynamoDB.Table #119

Closed llange closed 7 years ago

llange commented 7 years ago

We can now retrieve DynamoDB.Table tag list. Note: if boto3's documentation (http://boto3.readthedocs.io/en/latest/reference/services/dynamodb.html#DynamoDB.Client.list_tags_of_resource) and AWS API's documentation (https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_ListTagsOfResource.html), the API call is described as having the "NextToken" mechanism implemented. As far as I could see, skew's implementation relies on boto3's can_paginate / get_paginator to handle this. But it seems that boto3's latest version do not have a paginator for the list_tags_of_resource() call. I may have understood all this wrongly of course, but if it were true, we could loose some of the tags.

avram commented 7 years ago

Given the low maximum number of tags on resources, I suspect that pragmatically the API clients opt to ignore pagination, as having multiple pages would require Amazon changing their tag count limit first. The API is being more conservative.