search

scopely-devops / skew

Apache License 2.0
243 stars 70 forks source link

Get rid of YAML warning #152

Closed cameronezell closed 4 years ago

lhaig commented 4 years ago

I was going to do this but now I just have to add +1

Thanks @cameronezell

avram commented 4 years ago

@cameronezell @lhaig This doesn't test cleanly -- can you look at #161 and the failures there?

Closing in favor of #161 so we can track the test status cleanly

cameronezell commented 4 years ago

@avram Hi, it looks like the FullLoader attribute isn't present in the PyYaml version specified in the requirements.txt file. I think bumping up that version should work or I could test just changing safe_load to load and see if it eliminates the error despite the missing attribute.

avram commented 4 years ago

Those all sound like viable solutions. Happy to merge and a release a working version of this fix. 👍