fix: workload when container command or args contains `$` variables - Githubissues

score-spec / score-compose

Reference implementation for docker-compose target platform support

https://score.dev/

Apache License 2.0

445 stars 40 forks source link

fix: workload when container command or args contains `$` variables #120

Closed giesan closed 4 months ago

giesan commented 4 months ago

A suggestion for solving issue #105 with the $ variables in the commands and the arguments.

Description

Replaces the Dollar sign ($) in the variables in the command and argument strings with the double Dollar sign ($$).

What does this PR do?

Fix for the bug #105 .

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New chore (expected functionality to be implemented)

Checklist:

[ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
[x] I've signed off with an email address that matches the commit author.

giesan commented 4 months ago

Cool, this looks great. Is it ok if I merge it?

yes, please