search

score-spec / score-go

Reference library for parsing and loading Score files
Apache License 2.0
26 stars 6 forks source link

[bug] Support import of provisioners from private OCI/image registry #56

Open mathieu-benoit opened 1 month ago

mathieu-benoit commented 1 month ago

Now that we support the import of provisioners from public OCI registry/image with https://github.com/score-spec/score-go/pull/48, let's now support the import of provisioners from private OCI registry/image.

High level flow to support this:

$ docker login|oras login...
$ ...--import oci.//...

Currently, the oci provisioner import does not inherit the docker creds or any other registry sessions, so private registries cannot be used.

Thoughts here but open to suggestion, we should just support the dynamic login approach ("using Docker credentials") like illustrated here: https://github.com/oras-project/oras-go/blob/main/example_test.go#L106, as opposed to support static approach like with user/passwork or token.

7h3-3mp7y-m4n commented 1 month ago

I like the dynamic login approach which is also mentioned here: https://github.com/oras-project/oras-go/blob/main/example_test.go#L121 , It can also improve the user experience :) And I would love to work on it :)

astromechza commented 1 month ago

Yeah if it's easy enough and we already have the code in the oras library, then we should do this 👍

astromechza commented 1 week ago

done in #48 and #59

mathieu-benoit commented 1 week ago

Actually, we need to support the access to private oci registry, which is not in place yet, so re-opening ;)

7h3-3mp7y-m4n commented 1 week ago

So is it open to work again?:)

astromechza commented 1 week ago

Ah Apologies @mathieu-benoit - let me edit the description a little to make this clear.

@7h3-3mp7y-m4n yes please go ahead