search

score-spec / score-k8s

A reference Score implementation that targets Kubernetes
https://score.dev/
Apache License 2.0
18 stars 8 forks source link

fix: remove default replicas=1 value from workload conversion #27

Closed astromechza closed 2 weeks ago

astromechza commented 2 weeks ago

This was mentioned in #25 as causing issues with deployments that have an HPA or have been scaled up by hand already. I'm not entirely sure why we had this default, possibly due to a previous proof of concept or example. Not breaking change since 1 is the default replicas.

Thanks @maxstepanov for bringing this to our attention!

mathieu-benoit commented 2 weeks ago

While it's done for Deployment, should it be done for StatefulSet too? https://github.com/score-spec/score-k8s/blob/main/internal/convert/workloads.go#L258