score-spec / score-k8s

A reference Score implementation that targets Kubernetes
https://docs.score.dev/docs/score-implementation/score-k8s/
Apache License 2.0
26 stars 13 forks source link

Remove `-svc` suffix in `Service` name for more consistency #33

Closed mathieu-benoit closed 2 months ago

mathieu-benoit commented 2 months ago

Remove -svc suffix in Service name for more consistency with Deployment name. Common pattern/naming out there.

Context, with this:

apiVersion: score.dev/v1b1
metadata:
  name: store-front
containers:
  store-front:
    image: .
    variables:
      VUE_APP_ORDER_SERVICE_URL: "http://${resources.order-service.name}:3000/"
resources:
  order-service:
    type: service

And this:

- uri: template://service-provisioners/static-service
  type: service
  init: |
    name: {{ splitList "." .Id | last }}
  outputs: |
    {{ $w := (index .WorkloadServices .Init.name) }}
    name: {{ $w.ServiceName | quote }}
mathieu-benoit commented 2 months ago

Closing to implement this in there https://github.com/score-spec/score-k8s/pull/34 now.