search

scorelab / Bassa

Automated Download Queue for Communities to take the best use of Internet bandwidth
GNU General Public License v3.0
168 stars 493 forks source link

Move to `gulp-htmlmin` from `gulp-minify-html` #252

Open agentmilindu opened 6 years ago

agentmilindu commented 6 years ago 
npm WARN deprecated gulp-minify-html@0.1.8: Please use gulp-htmlmin
tanmayanand44 commented 6 years ago

@agentmilindu I would like to work on this issue.

agentmilindu commented 6 years ago

@tanmayanand44 Awesome!

tanmayanand44 commented 6 years ago

@agentmilindu Can u guide me a little.

agentmilindu commented 6 years ago

@tanmayanand44 yeah, sure, check what gulp-minify-html did and gulp-htmlmin can do. Then change the code and see if any further changes are needed.

tanmayanand44 commented 6 years ago

@agentmilindu Do we also need to update yarn.lock and package.lock.json?

agentmilindu commented 6 years ago

@tanmayanand44 yes, if they got updated, then commit them also.

tanmayanand44 commented 6 years ago

@agentmilindu Sir,but it automatically install htmlmin dependency when running yarn command.

tanmayanand44 commented 6 years ago

@agentmilindu Please review.

vivonk commented 6 years ago

@agentmilindu @rehrumesh can we close this? it's resolved :)