scorelab / Bassa

Automated Download Queue for Communities to take the best use of Internet bandwidth
GNU General Public License v3.0
168 stars 493 forks source link

Adding missing logo in the readme.md file #895

Closed slahirucd7 closed 4 years ago

slahirucd7 commented 4 years ago

Description

In the readme.md file the logo associated to the product was missing. Therefore I changed it to display the logo.

Related Issue

N/A

Motivation and Context

Since this page gives the first impression to the user, better if repository have the missing logo.

How Has This Been Tested?

This was tested using locally as well as in the GitHub web readme.md web page of the repository.

Screenshots (In case of UI changes):

Types of changes

This how it was displayed before adding the image with new path image

This how now the product logo is going to be displayed in the repository image

Checklist:

kmehant commented 4 years ago

Looks like you have got few commits from the master branch added to your pull request can you remove them 😁

slahirucd7 commented 4 years ago

@JaDogg @kmehant Thank you for reviewing. Added suggested changes.

JaDogg commented 4 years ago

It would be easier to create a new pull request by branching from develop, updating README, then sending the pull request.

JaDogg commented 4 years ago

I can still see all the changes. No need to add what's in Master branch :)

slahirucd7 commented 4 years ago

@JaDogg Can you please check again now ?

JaDogg commented 4 years ago

Looks good to me. 😁😁😁

slahirucd7 commented 4 years ago

@kmehant Please review.

kmehant commented 4 years ago

@JaDogg Please add a review here as your old review has been ignored due to a merge commit 😄

slahirucd7 commented 4 years ago

@JaDogg Please review :)

deshankoswatte commented 4 years ago

Hi @csl7,@kmehant and @JaDogg,

I think this has already been fixed by https://github.com/scorelab/Bassa/pull/909.

JaDogg commented 4 years ago

I'm seeing a merge conflict. fix it please.

kmehant commented 4 years ago

Closing this Fixed at #909