Closed slahirucd7 closed 4 years ago
Looks like you have got few commits from the master branch added to your pull request can you remove them 😁
@JaDogg @kmehant Thank you for reviewing. Added suggested changes.
It would be easier to create a new pull request by branching from develop, updating README, then sending the pull request.
I can still see all the changes. No need to add what's in Master branch :)
@JaDogg Can you please check again now ?
Looks good to me. 😁😁😁
@kmehant Please review.
@JaDogg Please add a review here as your old review has been ignored due to a merge commit 😄
@JaDogg Please review :)
Hi @csl7,@kmehant and @JaDogg,
I think this has already been fixed by https://github.com/scorelab/Bassa/pull/909.
I'm seeing a merge conflict. fix it please.
Closing this Fixed at #909
Description
In the readme.md file the logo associated to the product was missing. Therefore I changed it to display the logo.
Related Issue
N/A
Motivation and Context
Since this page gives the first impression to the user, better if repository have the missing logo.
How Has This Been Tested?
This was tested using locally as well as in the GitHub web readme.md web page of the repository.
Screenshots (In case of UI changes):
Types of changes
This how it was displayed before adding the image with new path
This how now the product logo is going to be displayed in the repository
Checklist: