scorelab / Bassa

Automated Download Queue for Communities to take the best use of Internet bandwidth
GNU General Public License v3.0
168 stars 493 forks source link

Add register with strong password feature #898

Closed sahandilshan closed 4 years ago

sahandilshan commented 4 years ago

Description

With the current implementation of the Bassa app, new users can sing up with a low-level security password. But in this PR I'm validating the password at a high level, so the user has to input a password mix with uppercase, lowercase, and numbers.

Related Issue

Fix #897

Motivation and Context

Strong password improves security, When using a low-level password others can easily guess/hack the password.

Screenshots (In case of UI changes):

Annotation 2020-03-20 35442 Annotation 2020-03-20 235414 Annotation 2020-03-20 235442 Annotation 2020-03-20 2354142

Types of changes

Checklist:

kmehant commented 4 years ago

@sahandilshan Thanks for the pull request 🌟. Basically in your present design, you are firing all the warnings at a time for every change. Can you make a change here, you can write separate functions for separate checks and simultaneously fire only the concerned warnings rather firing all as a single string.

sahandilshan commented 4 years ago

@sahandilshan Thanks for the pull request 🌟. Basically in your present design, you are firing all the warnings at a time for every change. Can you make a change here, you can write separate functions for separate checks and simultaneously fire only the concerned warnings rather firing all as a single string.

Hi @kmehant, This change has been made by 74e3f1e544f928d7e94284ea0b72394916fbaa75 commit.

kmehant commented 4 years ago

Thanks for the updated work