scorelab / Bassa

Automated Download Queue for Communities to take the best use of Internet bandwidth
GNU General Public License v3.0
168 stars 493 forks source link

[Feat] Action buttons #912

Closed BLasan closed 4 years ago

BLasan commented 4 years ago

Description Resuming and Pausing features added for the downloading items.

Related Issue

911

Motivation and Context Users should be able to pause and resume the downloading items.

How Has This Been Tested? Manually tested by adding new urls to be downloaded.

Screenshots (In case of UI changes): bassa2

Types of changes

Checklist:

BLasan commented 4 years ago

@kmehant Please review the PR

kmehant commented 4 years ago

Thanks for the pull request. Sorry to mention, This new feature does not line up with Bassa goals IMHO, why? Downloads can be started or killed only at the administrator auth level (which is already there) and most importantly this partially rules out the idea of automated download queue.

Let me take another opinion from @JaDogg bro before updating the status of this pull request :)

kmehant commented 4 years ago

referencing https://github.com/scorelab/Bassa/pull/912#issuecomment-607014985 :)