search

scorelab / Bassa

Automated Download Queue for Communities to take the best use of Internet bandwidth
GNU General Public License v3.0
168 stars 493 forks source link

Get backend URL from env #927

Open kmehant opened 4 years ago

kmehant commented 4 years ago

Signed-off-by: K mehant 411843@student.nitandhra.ac.in

TravisBuddy commented 4 years ago

Hey @kmehant,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d9885a90-d5aa-11ea-8ca9-c37e1b84d109
TravisBuddy commented 4 years ago

Travis tests have failed

Hey @kmehant, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker build -f ui/Dockerfile.dev -t scoreucsc/bassa-ui:dev ui >/dev/null ``` The command '/bin/sh -c apt-get update && npm install && npm install --global bower gulp-cli && bower --allow-root install' returned a non-zero code: 1 ```
TravisBuddy Request Identifier: f0ac3040-d5fd-11ea-8ca9-c37e1b84d109
kmehant commented 4 years ago

Use environment variable apiUrl to set Bassa API url

TravisBuddy commented 4 years ago

Hey @kmehant,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0bb5a100-d603-11ea-8ca9-c37e1b84d109
TravisBuddy commented 4 years ago

Hey @kmehant,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 53767e70-d625-11ea-8693-3322afd57804
agentmilindu commented 4 years ago

Screenshot from 2020-08-04 15-39-19

Try this method.

See https://hub.docker.com/_/nginx

COPY the env.js.template to /etc/nginx/templates with placeholder

TravisBuddy commented 4 years ago

Hey @kmehant,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 9b4213c0-d717-11ea-85fc-4b61cecd2c91
TravisBuddy commented 4 years ago

Hey @kmehant,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 2beb4f90-d718-11ea-85fc-4b61cecd2c91
kmehant commented 4 years ago

@agentmilindu I have tested it now, it works well having apiUrl set for server URL is taking up the changes in run time on reloading the container.

But all server routes give out 404 because of this PR https://github.com/scorelab/Bassa/pull/890 which does not seem to work with WSGI and supervisord layers well. Works without WSGI and supervisord though.

kmehant commented 4 years ago

Screenshot from 2020-08-04 15-39-19

Try this method.

See https://hub.docker.com/_/nginx

COPY the env.js.template to /etc/nginx/templates with placeholder

Are you planning to have bassa server also routed through the same nginx 🤔, then how about mounting the nginx config with an another server block for Bassa server?