search

scorelab / Go-social

Community of today used to use mobile phones to make their life easier and Community based mobile applications are famous among them. There are several kind of community based applications in use and most of them are relating to a specific domain. But core components have similar features. Address this issue and saving development time by Introducing a common app template with customizable components for community based mobile applications , is the main purpose of this project.
Apache License 2.0
61 stars 89 forks source link

fixed dependencies issue #133

Closed Yash621 closed 2 years ago

Yash621 commented 2 years ago

This PR is with respect to issue #132

In package.json we have to update the version of react-native from 0.58.6 to 0.60.6 otherwise react-native-fbsdk throws dependencies issues.

Likewise we have to upgrade the version of react from 16.12.0 to 16.8.6 to make npm install work.

@shehand Please review it and let me know if any changes are required.

shehand commented 2 years ago

@Yash621, can you verify that with this change the app will still work? We had an issue in map component where it actually did not work on RN > 0.58

Yash621 commented 2 years ago

@shehand can you look into this issue #131 ,without making these changes I was unable to run the app, but after doing these changes I am running in the issue #131 .

shehand commented 2 years ago

@Yash621, upgrading the modules to latest is a must that we should do and I have no issue with it. I was wondering whether with this upgrade other components need to be updated too. There might be small chance that there are other dependencies that should be updated along with this other than just updating RN and React. And regarding the mentioned issue, there is no enough information. Could you just add more info(something like the debug log) to the issue so that we can ensure this dependency upgrade is a must that should be done at this moment.

Yash621 commented 2 years ago

@shehand I have fixed that issue by downgrading react-native version to ^0.60.0. after that I ran into this issue #134 ,but I fixed it, and also have posted a solution of it in this issue #134 ,so that it could be helpful for others