scorelab / LabelLab

An Image Analysis and Classification Platform for Machine Learning Researchers
Apache License 2.0
78 stars 112 forks source link

Issue #633: Fix insufficient password length warning #634

Closed AkMo3 closed 2 years ago

AkMo3 commented 2 years ago

Description

Added a warning label if the password length is less than 8 while entering a password.

Fixes #636

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Also, include screenshots of the app for the verification and reviewing purpose.

https://user-images.githubusercontent.com/69365878/161368311-e0484dc1-9fd6-4692-8571-ebcb9b1b1db6.mp4

Checklist:

amlannandy commented 2 years ago

@vaishnavi-gupta18 's PR for this was merged as she had raised the issue. In the future, clarify beforehand that no one else is working on this issue before starting work.

AkMo3 commented 2 years ago

Both the PRs solved totally different issues. This PRs aims to alert users while writing the password, while #635 aimed to display all the errors present after submitting (that may result in multiple errors on a single component at once, but it can be fixed in future).

amlannandy commented 2 years ago

Why did you reference issue #633 for it then? Creates unnecessary confusion. Create a new issue for it and link this PR with it. Reopening this. Will merge once a new issue is created.

AkMo3 commented 2 years ago

Well, this actually solves the specific issue :) the other solved a broader issue. Anyways, I will create a new issue.

Update: Issue created and updated.

amlannandy commented 2 years ago

Well, this actually solves the real issue :) the other solved a broader issue. Anyways, I will create a new issue

That doesn't matter in this context. As you said, these 2 PRs solve totally different issues. Hence, they have to be tracked separately.

635 solved exactly what #633 mentioned. So if this PR does something different, it has to be mentioned accordingly.