scorelab / OpenMF

An Open Source Mobile Forensics Investigation Tool for Android Platform
Apache License 2.0
146 stars 94 forks source link

Update Sidebar.js #255

Closed PrerakMathur20 closed 2 years ago

PrerakMathur20 commented 2 years ago

Description

The Home, Contact and About buttons in the Sidenav weren't functioning properly as they were not linked to their respective pages. The required changes were made and the following files were updated with the necessary changes:

Fixes #254

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Also, include screenshots for the verification and reviewing purpose. Not relevant

Checklist:

swapnalshahil commented 2 years ago

@PrerakMathur20 Did you test if it works when you log in with extractor or management role? I don't think this will work for them also!

PrerakMathur20 commented 2 years ago

@PrerakMathur20 Did you test if it works when you log in with extractor or management role? I don't think this will work for them also!

Yes, you're right, this fix isn't working for the extractor or management role. My bad. But don't worry I've figured out the issue and am currently working on fixing it. I'll update this PR soon.

PrerakMathur20 commented 2 years ago

I've made the required changes and now the Home, Contact and About, links on the Sidebar are now redirecting to their respective pages now for all Admin, Extractor and Management users.

Kindly review these changes and let me know if I've missed out anything 😄

PrerakMathur20 commented 2 years ago

My apologies. I have removed the .DS_Store file as well as included it in the .gitignore file.