search

scorelab / TrackPal

TrackPal
Apache License 2.0
5 stars 36 forks source link

AndroidX fixes #44

Closed JosephSemrai closed 4 years ago

JosephSemrai commented 4 years ago

Allows the project to build with some of the conflicts that react-native-fbsdk brings about (temporary solution until the dependency is updated).

Updated build process to use Jettifier and target AndroidX. Also updates annotation calls to use the new AndroidX package.

viraj-dhanushka commented 4 years ago

Still getting errors #53

JosephSemrai commented 4 years ago

@viradhanus Try cleaning using gradle clean and see if you can run it then.

Also, what's your environment info (react-native info) + Java version?

viraj-dhanushka commented 4 years ago

@viradhanus Try cleaning using gradle clean and see if you can run it then.

Also, what's your environment info (react-native info) + Java version? Screenshot (72)

viraj-dhanushka commented 4 years ago

@viradhanus Try cleaning using gradle clean and see if you can run it then.

Also, what's your environment info (react-native info) + Java version?

I tried with ubuntu as well..

Screenshot from 2020-01-27 15-04-10

viraj-dhanushka commented 4 years ago

@viradhanus Try cleaning using gradle clean and see if you can run it then. Also, what's your environment info (react-native info) + Java version?

I tried with ubuntu as well..

Screenshot from 2020-01-27 15-04-10

Here are the environment info

Screenshot from 2020-01-27 15-18-44

JosephSemrai commented 4 years ago

Hmm, I will check the issue out when I get home. There might be another loose dependency.

On Mon, Jan 27, 2020 at 5:29 AM Viraj Dhanushka notifications@github.com wrote:

@viradhanus https://github.com/viradhanus Try cleaning using gradle clean and see if you can run it then. Also, what's your environment info (react-native info) + Java version?

I tried with ubuntu as well..

[image: Screenshot from 2020-01-27 15-04-10] https://user-images.githubusercontent.com/59219626/73167388-cbf66100-411d-11ea-8c31-9f73c07b0ce6.png

Here are the environment info

[image: Screenshot from 2020-01-27 15-18-44] https://user-images.githubusercontent.com/59219626/73167515-f9430f00-411d-11ea-9012-6dd1cf2cd4cd.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/scorelab/TrackPal/pull/44?email_source=notifications&email_token=AG5I3OWXIJHRXZNQPPKUO4TQ72ZQNA5CNFSM4KI4KXI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ7AQJQ#issuecomment-578684966, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG5I3OS5VNZVZX2LISM5Q73Q72ZQNANCNFSM4KI4KXIQ .

viraj-dhanushka commented 4 years ago

Hmm, I will check the issue out when I get home. There might be another loose dependency.

Sure keep it up... :blush:

viraj-dhanushka commented 4 years ago

@JosephSemrai Can I know your environment info? Sometimes there may be changes that you have done, not listed here. Can you compare package.json as well?

shehand commented 4 years ago

Feature merged with the PR #58